Bug 449625 - crash in gtk_tree_view_real_move_cursor at gtktreeview.c:9641

2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Bug 449625 - crash in gtk_tree_view_real_move_cursor at
	gtktreeview.c:9641

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down):
	cursor_offset *must* be larger than background height of the cursor
	node, not just equal otherwise there is no guarantee there is a next
	node.

svn path=/trunk/; revision=20219

diff --git a/ChangeLog b/ChangeLog
index 16501567855d876314880a509e0ee4c1a4e78fd6..90db48a9fa58c90b028eddabc6f9c524c88159f5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-05-28  Kristian Rietveld  <kris@imendio.com>
+
+       Bug 449625 - crash in gtk_tree_view_real_move_cursor at
+       gtktreeview.c:9641
+
+       * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down):
+       cursor_offset *must* be larger than background height of the cursor
+       node, not just equal otherwise there is no guarantee there is a next
+       node.
+
 2008-05-28  Michael Natterer  <mitch@imendio.com>
 
        * gtk/gtktestutils.c: don't include <gdk/gdktestutils.h>.

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index f4b4705aabe710f43be358b94ae18dcadd96986b..455a4fa3a7f6dc6cb5f42cd6e894509c7d45786e 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -9748,7 +9748,7 @@ gtk_tree_view_move_cursor_page_up_down (GtkTreeView *tree_view,
     _gtk_rbtree_find_offset (tree_view->priv->tree, y,
                             &cursor_tree, &cursor_node);
 
-  if (tree_view->priv->cursor_offset >= BACKGROUND_HEIGHT (cursor_node))
+  if (tree_view->priv->cursor_offset > BACKGROUND_HEIGHT (cursor_node))
     {
       _gtk_rbtree_next_full (cursor_tree, cursor_node,
                             &cursor_tree, &cursor_node);